Upgrade to Xcode 16.2 for testflight builds#4909
Merged
philipphofmann merged 12 commits intomainfrom Mar 4, 2025
Merged
Conversation
This should fix the warning about building without iOS 18 SDK.
krystofwoldrich
requested review from
armcknight,
philipphofmann and
philprime
as code owners
Contributor
Author
|
The upload fails on |
Member
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4909 +/- ##
=============================================
- Coverage 92.408% 92.407% -0.002%
=============================================
Files 660 660
Lines 77732 77732
Branches 28154 28151 -3
=============================================
- Hits 71831 71830 -1
Misses 5804 5804
- Partials 97 98 +1 see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 26af50b | 1223.78 ms | 1245.93 ms | 22.16 ms |
| f1d1166 | 1237.54 ms | 1256.06 ms | 18.52 ms |
| 7207796 | 1223.80 ms | 1235.92 ms | 12.11 ms |
| dacf894 | 1232.32 ms | 1236.34 ms | 4.02 ms |
| adcc7d8 | 1225.90 ms | 1245.08 ms | 19.18 ms |
| 736495a | 1245.16 ms | 1254.42 ms | 9.26 ms |
| 421cd69 | 1226.96 ms | 1250.18 ms | 23.23 ms |
| 542727d | 1227.96 ms | 1246.88 ms | 18.92 ms |
| b07998b | 1216.88 ms | 1244.18 ms | 27.31 ms |
| 98752f3 | 1226.18 ms | 1251.38 ms | 25.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 26af50b | 21.58 KiB | 542.38 KiB | 520.80 KiB |
| f1d1166 | 21.58 KiB | 630.74 KiB | 609.16 KiB |
| 7207796 | 21.58 KiB | 418.14 KiB | 396.56 KiB |
| dacf894 | 20.76 KiB | 426.34 KiB | 405.58 KiB |
| adcc7d8 | 20.76 KiB | 426.15 KiB | 405.39 KiB |
| 736495a | 20.76 KiB | 435.22 KiB | 414.46 KiB |
| 421cd69 | 22.31 KiB | 780.75 KiB | 758.43 KiB |
| 542727d | 21.58 KiB | 571.85 KiB | 550.26 KiB |
| b07998b | 22.30 KiB | 749.77 KiB | 727.47 KiB |
| 98752f3 | 20.76 KiB | 435.09 KiB | 414.33 KiB |
Member
|
There is a known issue with Xcode 16; fastlane/fastlane#22276. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Although GH docs say ios 18.2 is present on macos-14 runners (https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md#installed-sdks), it doesn't seem to be the case by default https://github.com/getsentry/sentry-cocoa/actions/runs/13554352815/job/37885252787?pr=4909
So I bumped the job to macos-15.